Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve an issue where the user would be presented with the Session expired dialog when the user would be logging in during the checkout process. #2205

Merged
merged 14 commits into from
Feb 19, 2024
Merged

Solve an issue where the user would be presented with the Session expired dialog when the user would be logging in during the checkout process. #2205

merged 14 commits into from
Feb 19, 2024

Conversation

paales
Copy link
Member

@paales paales commented Feb 14, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5a62623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@graphcommerce/ecommerce-ui Patch
@graphcommerce/magento-cart-shipping-address Patch
@graphcommerce/magento-newsletter Patch
@graphcommerce/magento-cart Patch
@graphcommerce/magento-customer Patch
@graphcommerce/magento-graphcms Patch
@graphcommerce/docs Patch
@graphcommerce/browserslist-config-pwa Patch
@graphcommerce/changeset-changelog Patch
@graphcommerce/eslint-config-pwa Patch
@graphcommerce/graphql-codegen-markdown-docs Patch
@graphcommerce/graphql-codegen-near-operation-file Patch
@graphcommerce/graphql-codegen-relay-optimizer-plugin Patch
@graphcommerce/next-config Patch
@graphcommerce/prettier-config-pwa Patch
@graphcommerce/typescript-config-pwa Patch
@graphcommerce/address-fields-nl Patch
@graphcommerce/algolia-search Patch
@graphcommerce/cli Patch
@graphcommerce/demo-magento-graphcommerce Patch
@graphcommerce/framer-next-pages Patch
@graphcommerce/framer-scroller Patch
@graphcommerce/framer-utils Patch
@graphcommerce/googleanalytics Patch
@graphcommerce/googlerecaptcha Patch
@graphcommerce/googletagmanager Patch
@graphcommerce/graphql-mesh Patch
@graphcommerce/graphql Patch
@graphcommerce/hygraph-cli Patch
@graphcommerce/hygraph-dynamic-rows-ui Patch
@graphcommerce/hygraph-dynamic-rows Patch
@graphcommerce/graphcms-ui Patch
@graphcommerce/image Patch
@graphcommerce/lighthouse Patch
@graphcommerce/lingui-next Patch
@graphcommerce/magento-cart-billing-address Patch
@graphcommerce/magento-cart-checkout Patch
@graphcommerce/magento-cart-coupon Patch
@graphcommerce/magento-cart-email Patch
@graphcommerce/magento-cart-items Patch
@graphcommerce/magento-cart-payment-method Patch
@graphcommerce/magento-cart-pickup Patch
@graphcommerce/magento-cart-shipping-method Patch
@graphcommerce/magento-category Patch
@graphcommerce/magento-cms Patch
@graphcommerce/magento-compare Patch
@graphcommerce/magento-customer-account Patch
@graphcommerce/magento-customer-order Patch
@graphcommerce/magento-graphql Patch
@graphcommerce/magento-pagebuilder Patch
@graphcommerce/magento-payment-adyen Patch
@graphcommerce/magento-payment-braintree Patch
@graphcommerce/magento-payment-included Patch
@graphcommerce/magento-payment-klarna Patch
@graphcommerce/magento-payment-multisafepay Patch
@graphcommerce/magento-payment-paypal Patch
@graphcommerce/magento-product-bundle Patch
@graphcommerce/magento-product-configurable Patch
@graphcommerce/magento-product-downloadable Patch
@graphcommerce/magento-product-grouped Patch
@graphcommerce/magento-product-simple Patch
@graphcommerce/magento-product-virtual Patch
@graphcommerce/magento-product Patch
@graphcommerce/magento-recently-viewed-products Patch
@graphcommerce/magento-review Patch
@graphcommerce/magento-search Patch
@graphcommerce/magento-store Patch
@graphcommerce/magento-wishlist Patch
@graphcommerce/mollie-magento-payment Patch
@graphcommerce/next-ui Patch
@graphcommerce/react-hook-form Patch
@graphcommerce/framer-next-pages-example Patch
@graphcommerce/framer-scroller-example Patch
@graphcommerce/image-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Feb 19, 2024 11:19am
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Feb 19, 2024 11:19am

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 13.9kB -0.1kB 282kB 282.0kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 13.9kB -0.1kB 282kB 282.0kB

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 13.9kB -0.1kB 282kB 282.0kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 14.1kB 0.1kB 282kB 282.0kB

@paales paales changed the title Assign the customer cart directly so there wont be a query made with the guest cart Solve an issue where the user would be presented with the Session expired dialog when the user would be logging in during the checkout process. Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 14.1kB 0.1kB 282kB 282.0kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/test/buttons 5.1kB 5.1kB 218kB 219.0kB +1kB⚠️

@paales
Wait for queries to resolve by default, this might introduce an addit…
eb14696 
…ional spinner but prevents a flash where it is shown that there is no cart
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/blog/tagged/[url] 1.6kB 1.6kB 295kB 296.0kB +1kB⚠️
/test/buttons 5.1kB 5.1kB 218kB 219.0kB +1kB⚠️

@paales
Deprecate the allowUrl option for useCartQuery, it was already enable…
d67c89d 
…d by default and should never be set to false.
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/blog/tagged/[url] 1.6kB 1.6kB 295kB 296.0kB +1kB⚠️
/test/buttons 5.1kB 5.1kB 218kB 219.0kB +1kB⚠️

@paales
Cleanup cart merge logic and make sure the cart gets unlocked after r…
d47c94e 
…evalidating the cart, introduce utility function readCartId
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 13.5kB -0.5kB 282kB 282.0kB
/blog/tagged/[url] 1.6kB 1.6kB 295kB 296.0kB +1kB⚠️
/checkout 7.4kB 8.5kB +1.1kB⚠️ 277kB 276.0kB -1kB
/checkout/payment 13.8kB 13.7kB -0.1kB 292kB 292.0kB
/test/buttons 5.1kB 5.1kB 218kB 219.0kB +1kB⚠️
/test/sheet 5.1kB 5.1kB 232kB 233.0kB +1kB⚠️

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 14.0kB 13.5kB -0.5kB 282kB 282.0kB
/blog/tagged/[url] 1.6kB 1.6kB 295kB 296.0kB +1kB⚠️
/checkout 7.4kB 8.5kB +1.1kB⚠️ 277kB 276.0kB -1kB
/test/buttons 5.1kB 5.1kB 218kB 219.0kB +1kB⚠️
/test/sheet 5.1kB 5.1kB 232kB 233.0kB +1kB⚠️

@paales paales merged commit eedcd58 into canary Feb 19, 2024
4 checks passed
@paales paales deleted the fix/customer-cart-assignment branch February 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paales